[Okular-devel] Review Request: Merge request for 'viewerinterface' branch

[Michel Ludwig]

> On Oct. 23, 2011, 12:46 p.m., Albert Astals Cid wrote:
> > I've made a "very quick review" that mostly covers superficial things, did not dig into the features yet, but thought of publishing this so you can start of fixing these minor things.

Yes, that's a good idea. Sorry about the numerous coding style issues, I've tried as hard as I could, but old habits seem hard to break :)

And thanks for your time!


> On Oct. 23, 2011, 12:46 p.m., Albert Astals Cid wrote:
> > conf/okular.kcfg, line 6
> > <http://git.reviewboard.kde.org/r/102946/diff/1/?file=39518#file39518line6>
> >
> >     Why?

This allows to specify which configuration file should be used. This is also important as the users of Kile won't see all the available configuration options. If the default config file would be used in Kile, they might not be able change some settings. Of course, if no config file is specified, "okularpartrc" will be used again.


> On Oct. 23, 2011, 12:46 p.m., Albert Astals Cid wrote:
> > part.cpp, line 510
> > <http://git.reviewboard.kde.org/r/102946/diff/1/?file=39527#file39527line510>
> >
> >     Why?

All those shortcuts were in use already in Kile / KatePart. Note that 'ALT' is only added in viewer mode, for regular Okular users, nothing changes. Is that ok?


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102946/#review7548
-----------------------------------------------------------


On Oct. 23, 2011, 10:24 a.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102946/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 10:24 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The functionality that I need for Kile should now be implemented, i.e. handling of source references, disabling of certain actions and configuration options in 'ViewerWidgetMode', and drawing of source locations.
> 
> Note that currently the drawing of source locations doesn't work correctly for rotated pages. This is due to the fact that locating source references for rotated doesn't seem to be implemented in Okular yet. I'm thinking of disabling the rotate-page actions in 'ViewerWidgetMode' until this is implemented in Okular.
> 
> If you want to see the viewer mode in action, you can try it out by following the instructions given here:
> 
> http://sourceforge.net/apps/mediawiki/kile/index.php?title=Live_Preview
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f8dcba0 
>   conf/dlggeneral.h 1ee2768 
>   conf/dlggeneral.cpp 80478e6 
>   conf/okular.kcfg b7d511c 
>   conf/preferencesdialog.h 72a7072 
>   conf/preferencesdialog.cpp 5ea6269 
>   core/document.h 2bcf280 
>   core/document.cpp a417828 
>   core/global.h 24cef77 
>   interfaces/viewerinterface.h PRE-CREATION 
>   part-viewermode.rc PRE-CREATION 
>   part.h f30eb6d 
>   part.cpp 9219db7 
>   ui/pagepainter.h 4044dd8 
>   ui/pagepainter.cpp 2bd2f23 
>   ui/pageview.h b89f346 
>   ui/pageview.cpp b119e82 
> 
> Diff: http://git.reviewboard.kde.org/r/102946/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111023/49bfcc6f/attachment.html>