[Okular-devel] Review Request: Merge request for 'viewerinterface' branch

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102946/#review7548
-----------------------------------------------------------


I've made a "very quick review" that mostly covers superficial things, did not dig into the features yet, but thought of publishing this so you can start of fixing these minor things.


conf/okular.kcfg
<http://git.reviewboard.kde.org/r/102946/#comment6543>

    Why?



core/document.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6544>

    can you please make it "emit sourceRefe" without the ( in there?



part.h
<http://git.reviewboard.kde.org/r/102946/#comment6536>

    Please use a * and not a & for output parameters



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6534>

    Move the { to the next line to keep style



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6533>

    "" -> QString



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6535>

    unbalanced spaces, doens't follow neighbour if code style



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6537>

    Why?



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6538>

    Why?



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6539>

    Why?



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6540>

    Why?



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6541>

    wrong style {



part.cpp
<http://git.reviewboard.kde.org/r/102946/#comment6542>

    Please replace all the NULL with 0 since it is mostly our style


- Albert Astals Cid


On Oct. 23, 2011, 10:24 a.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102946/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 10:24 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The functionality that I need for Kile should now be implemented, i.e. handling of source references, disabling of certain actions and configuration options in 'ViewerWidgetMode', and drawing of source locations.
> 
> Note that currently the drawing of source locations doesn't work correctly for rotated pages. This is due to the fact that locating source references for rotated doesn't seem to be implemented in Okular yet. I'm thinking of disabling the rotate-page actions in 'ViewerWidgetMode' until this is implemented in Okular.
> 
> If you want to see the viewer mode in action, you can try it out by following the instructions given here:
> 
> http://sourceforge.net/apps/mediawiki/kile/index.php?title=Live_Preview
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f8dcba0 
>   conf/dlggeneral.h 1ee2768 
>   conf/dlggeneral.cpp 80478e6 
>   conf/okular.kcfg b7d511c 
>   conf/preferencesdialog.h 72a7072 
>   conf/preferencesdialog.cpp 5ea6269 
>   core/document.h 2bcf280 
>   core/document.cpp a417828 
>   core/global.h 24cef77 
>   interfaces/viewerinterface.h PRE-CREATION 
>   part-viewermode.rc PRE-CREATION 
>   part.h f30eb6d 
>   part.cpp 9219db7 
>   ui/pagepainter.h 4044dd8 
>   ui/pagepainter.cpp 2bd2f23 
>   ui/pageview.h b89f346 
>   ui/pageview.cpp b119e82 
> 
> Diff: http://git.reviewboard.kde.org/r/102946/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111023/f420135a/attachment-0001.html>