[Okular-devel] Review Request: Modify behaviour for 'facing pages' mode to have pages touch at the center

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103194/#review8356
-----------------------------------------------------------



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/103194/#comment7131>

    If you want this to go in KDE 4.8 this has to be reverted since no string changes are allowed anymore.
    
    On the other hand I am not really sure I do want this feature in without it being an option. I'm sure someone likes it more like it is now than tied together...



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/103194/#comment7129>

    Unrelated, please remove from the patch



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/103194/#comment7130>

    Please do not use >> 1, makes no sense and makes code far unreadable (applies for the other lines of this change too)


- Albert Astals Cid


On Nov. 20, 2011, 10:32 p.m., Stephen Anthony wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103194/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2011, 10:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> The following patch addresses several issues with 'facing pages' mode:
> 
> 1)  Facing pages are now touching each other on the center dividing line, instead of being centered within their own virtual column.  This makes the output much more like reading from a book or magazine.
> 
> 2)  If "Center First Page" is activated, the last page of the document is also centered *if* it would be in the view by itself.  Previously, this page was always on the left.  It looks better to have the front and back covers centered across the entire viewable area.
> 
> 3)  The "Facing Pages (Center First Page)"  has been renamed to "Book Mode", to more clearly indicate its intent.
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook 7399fe2 
>   ui/pageview.cpp 56be30d 
> 
> Diff: http://git.reviewboard.kde.org/r/103194/diff/diff
> 
> 
> Testing
> -------
> 
> After making these changes, all view modes and continuous viewing were tested.  The only behaviour that has changed is in "Facing Page" modes; the behaviour of all other modes works the same as before.
> 
> 
> Thanks,
> 
> Stephen Anthony
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111120/b20bb280/attachment-0001.html>