<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103194/">http://git.reviewboard.kde.org/r/103194/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103194/diff/1/?file=41580#file41580line478" style="color: black; font-weight: bold; text-decoration: underline;">ui/pageview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">do { \</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">478</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ADD_VIEWMODE_ACTION</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"<span class="hl">Facing Pages (Center First Page)</span>"</span> <span class="p">),</span> <span class="s">"view_render_mode_facing_center_first"</span><span class="p">,</span> <span class="p">(</span><span class="kt">int</span><span class="p">)</span><span class="n">Okular</span><span class="o">::</span><span class="n">Settings</span><span class="o">::</span><span class="n">EnumViewMode</span><span class="o">::</span><span class="n">FacingFirstCentered</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">478</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ADD_VIEWMODE_ACTION</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"<span class="hl">Book Mode</span>"</span> <span class="p">),</span> <span class="s">"view_render_mode_facing_center_first"</span><span class="p">,</span> <span class="p">(</span><span class="kt">int</span><span class="p">)</span><span class="n">Okular</span><span class="o">::</span><span class="n">Settings</span><span class="o">::</span><span class="n">EnumViewMode</span><span class="o">::</span><span class="n">FacingFirstCentered</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you want this to go in KDE 4.8 this has to be reverted since no string changes are allowed anymore.
On the other hand I am not really sure I do want this feature in without it being an option. I'm sure someone likes it more like it is now than tied together...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103194/diff/1/?file=41580#file41580line3699" style="color: black; font-weight: bold; text-decoration: underline;">ui/pageview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PageView::slotRelayoutPages()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">3696</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">insertY</span> <span class="o">=</span> <span class="n">fullHeight</span> <span class="o"><</span> <span class="n">viewportHeight</span> <span class="o">?</span> <span class="p">(</span> <span class="n">viewportHeight</span> <span class="o">-</span> <span class="n">fullHeight</span> <span class="p">)</span> <span class="o"><span class="hl">/</span></span><span class="hl"> </span><span class="mi"><span class="hl">2</span></span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3699</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">insertY</span> <span class="o">=</span> <span class="n">fullHeight</span> <span class="o"><</span> <span class="n">viewportHeight</span> <span class="o">?</span> <span class="p">(<span class="hl">(</span></span> <span class="n">viewportHeight</span> <span class="o">-</span> <span class="n">fullHeight</span> <span class="p">)</span> <span class="o"><span class="hl">>></span></span><span class="hl"> </span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">)</span></span> <span class="o">:</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unrelated, please remove from the patch</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103194/diff/1/?file=41580#file41580line3722" style="color: black; font-weight: bold; text-decoration: underline;">ui/pageview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PageView::slotRelayoutPages()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3722</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">actualX</span> <span class="o">=</span> <span class="p">(</span><span class="n">fullWidth</span> <span class="o">-</span> <span class="n">item</span><span class="o">-></span><span class="n">croppedWidth</span><span class="p">())</span> <span class="o">>></span> <span class="mi">1</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please do not use >> 1, makes no sense and makes code far unreadable (applies for the other lines of this change too)</pre>
</div>
<br />
<p>- Albert</p>
<br />
<p>On November 20th, 2011, 10:32 p.m., Stephen Anthony wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Stephen Anthony.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2011, 10:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The following patch addresses several issues with 'facing pages' mode:
1) Facing pages are now touching each other on the center dividing line, instead of being centered within their own virtual column. This makes the output much more like reading from a book or magazine.
2) If "Center First Page" is activated, the last page of the document is also centered *if* it would be in the view by itself. Previously, this page was always on the left. It looks better to have the front and back covers centered across the entire viewable area.
3) The "Facing Pages (Center First Page)" has been renamed to "Book Mode", to more clearly indicate its intent.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After making these changes, all view modes and continuous viewing were tested. The only behaviour that has changed is in "Facing Page" modes; the behaviour of all other modes works the same as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/index.docbook <span style="color: grey">(7399fe2)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(56be30d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103194/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>