[Okular-devel] [Bug 181290] Landscape pdf prints with wrong orientation when choosing landscape in print dialog

[Falk]

https://bugs.kde.org/show_bug.cgi?id=181290





--- Comment #93 from Falk <faah gmx de>  2011-05-08 10:38:28 ---
The orientation detection code isn't copy paste, because it works over a
different data structure. But the idea behind it is the same. It uses the page
height and width to decide if a the page is landscape or portrait. If the
majority of the pages are in landscape the document orientation is set to
landscape.

But as Kevin already pointed out, it is not very clever to have the detection
code at two places. Because as soon as one is changed and the other one isn't
the printing will break again. 

The okular printer page orientation detection is in a file called 'part.cpp' in
a function called 'setupPrinter'. But from there I see no way of passing the
information detected there to the printer code without breaking the API for the
so called document generators.

So for now it looks like we have to live with the fact that the document
orientation is detected twice by different code.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.