[Okular-devel] Re: [patch] Revised revision toolbar

[Raffaele Mancuso]

2011/1/30 Albert Astals Cid <aacid at kde.org>

>  > Let me know what you thinks and if the patch will be applied or not.
> > Critics are very appreciated :)
>
> You have lots of "this->" that should not be there, since "this" is already
> implied, and the indentation seems a bit off like if we use spaces and you
> use
> tabs or viceversa. But this all look very minor.
>
>
Thanks for the response. I will try to stick better with your coding style
next time. Using the same style sure makes all the code more organic and
readable :)


> In general i like the patch, tomorrow i'll have a more calm look at it and
> probably commit it if i don't find anything really wrong.
>
> Thanks for the patch :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/okular-devel/attachments/20110131/fc92ca15/attachment.htm