<br><br><div class="gmail_quote">2011/1/30 Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span><br><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
<div>
> Let me know what you thinks and if the patch will be applied or not.<br>
> Critics are very appreciated :)<br>
<br>
</div>You have lots of "this->" that should not be there, since "this" is already<br>
implied, and the indentation seems a bit off like if we use spaces and you use<br>
tabs or viceversa. But this all look very minor.<br>
<br></blockquote><div><br>Thanks for the response. I will try to stick better with your coding style next time. Using the same style sure makes all the code more organic and readable :)<br> <br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204, 204, 204);padding-left:1ex">
In general i like the patch, tomorrow i'll have a more calm look at it and<br>
probably commit it if i don't find anything really wrong.<br>
<br>
Thanks for the patch :-)</blockquote></div>