[Okular-devel] Review Request: Add greedy preloading option

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103129/#review9098
-----------------------------------------------------------


Please fix these minor formatting issues.

Also i'm not sure of the "For systems with more than 2GB" wording as it seems it would be the recommended systems for those systems. I'd remove that an maybe add a reference saying "Will use as much memory as possible" Or something like that? Or maybe not even that? The reference to caching all and keeping as much as possible shall be enough?

Also, don't know if it was clear when we spoke but 4.8 is frozen for new features so this is 4.9 material.


conf/okular.kcfg
<http://git.reviewboard.kde.org/r/103129/#comment7524>

    Can you fix the spacing here?



core/document.cpp
<http://git.reviewboard.kde.org/r/103129/#comment7525>

    can you remove the whitespaces after break?



ui/presentationwidget.cpp
<http://git.reviewboard.kde.org/r/103129/#comment7526>

    Your spacing seems a bit broke in this block too, and there's an unneeded empty line at the end


- Albert Astals Cid


On Dec. 16, 2011, 8:22 p.m., Sebastian Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103129/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 8:22 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> -------
> 
> After discovering that the aggressive behaviour in okular is not that aggressive at all (preloads only the next 2 pages) I've written the attached patch to add a "Greedy" option. It preloads every page into memory.
> 
> 
> Diffs
> -----
> 
>   conf/dlgperformance.cpp fd0e30b 
>   conf/dlgperformancebase.ui b022f56 
>   conf/okular.kcfg 430af7c 
>   core/document.cpp 74757f1 
>   ui/pageview.cpp 78a007a 
>   ui/presentationwidget.cpp 7c3f618 
> 
> Diff: http://git.reviewboard.kde.org/r/103129/diff/diff
> 
> 
> Testing
> -------
> 
> Tested it on my local system, I'm using the modified okular with the new greedy option checked and don't have any issues so far. The memory requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It takes a while for the whole document to be prerendered but after that it works as expected.
> 
> 
> Thanks,
> 
> Sebastian Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111219/42f575d6/attachment.html>