[Okular-devel] Review Request: Add greedy preloading option

[Sebastian Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103129/
-----------------------------------------------------------

(Updated Dec. 16, 2011, 8:22 p.m.)


Review request for Okular.


Changes
-------

Added changes to PresentationWidget::requestPixmaps.


Description
-------

After discovering that the aggressive behaviour in okular is not that aggressive at all (preloads only the next 2 pages) I've written the attached patch to add a "Greedy" option. It preloads every page into memory.


Diffs (updated)
-----

  conf/dlgperformance.cpp fd0e30b 
  conf/dlgperformancebase.ui b022f56 
  conf/okular.kcfg 430af7c 
  core/document.cpp 74757f1 
  ui/pageview.cpp 78a007a 
  ui/presentationwidget.cpp 7c3f618 

Diff: http://git.reviewboard.kde.org/r/103129/diff/diff


Testing
-------

Tested it on my local system, I'm using the modified okular with the new greedy option checked and don't have any issues so far. The memory requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It takes a while for the whole document to be prerendered but after that it works as expected.


Thanks,

Sebastian Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20111216/3aea9e01/attachment.html>