[Okular-devel] Background in okular "shell" app

[Hugo Pereira Da Costa]

On 01/30/2010 05:49 PM, Pino Toscano wrote:
> Alle domenica 31 gennaio 2010, Hugo Pereira Da Costa ha scritto:
>    
>> To me, the plain background you get when calling autofillbackground
>> (using the palette.color( widget->backgroundrole() ), is a feature, not
>> a bug.
>>      
> See, color() != brush(). This Qt behaviour is basically bugging every widget
> which sets the autoFill and has the background role in the palette with
> something else than a color.
>
>    
ok, I agree with this.

But that wont fix the issue with oxygen. its main window background is 
not a brush, passed via the palette.
Maybe it could be made so (though I'm not sure about clipping), but it 
is not at the moment. Right now its plain painting (with QPainter) in 
re-implemented QEvent::Paint for appropriate (top level) widgets.

>> if okular wants to leave it this way:
>> - no I wont consider it as an oxygen bug and wont fix any bug report on
>> that (notably, not to break gwenview)
>>      
> As it looks to me, it is a Qt bug (forcing the use of a color from the palette
> instead of using the brush).
>
>    
>> - will live with that, and patch my local okular.
>>
>> I was just suggesting.
>>      
> Me as well.
>
> ... but well, why I am caring about it at all, given I'm not the Okular
> maintainer?!?! shame.
>    
me neither ! I was just thinking that if a 4 lines patch (when properly 
indented) can fix the appearance of okular with oxygen, and bespin (the 
only two decos which use background gradients AFAK), without breaking 
anything else, then its worth the change.
I usually have nothing against fixing bugs in oxygen style (make a svn 
log on kstyles/oxygen/oxygen.cpp :-))
And most of all, I really really don't want to enter in any kind of 
conflict with valuable devs.

> Feel free to commit it, if anybody else wants it. (In that case, please at
> least fix the indentation, thanks.)
>
>    
>
>
> _______________________________________________
> Okular-devel mailing list
> Okular-devel at kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
>    

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/okular-devel/attachments/20100130/3d59a36d/attachment-0001.htm