[Okular-devel] Background in okular "shell" app

[Hugo Pereira Da Costa]

Hi again Albert,

So 4 more screenshot:
- http://www.flickr.com/photos/42123798@N03/4316730697/sizes/o/
see the change of background color just above "thumbnails"

- http://www.flickr.com/photos/42123798@N03/4316730727/sizes/o/
see the change of background just below the "pages"

- http://www.flickr.com/photos/42123798@N03/4317463988/sizes/o/
- http://www.flickr.com/photos/42123798@N03/4316730801/sizes/o/
they're gone :-)
Now the entire window appears with one big unique background, which has 
some subtle backgrounds, and are part of oxygen "signature".

I know the change is subtle, and maybe a bit "picky", but there are a 
couple of picky people on irc#oxygen
(and I'm becoming one of them over time :-))

As for an embedded screenshot:

http://www.flickr.com/photos/42123798@N03/4317482020/sizes/o/

(this is not a jpg image of okular. It is actually working. You can move 
the scrollbar, change page, etc, but embedded in an HTML page. Here if 
you setAutoFillBackground to "false" the entire okular window would get 
the background of the parent, that is: white. Not good)

That's why the patch I sent have this "if" statement.

Keep me posted,

Hugo

> A Divendres, 29 de gener de 2010, Hugo Pereira Da Costa va escriure:
>    
>> Dear Okular devs,
>>
>> First: I must say I really love okular, uses it on a daily basis, find
>> it robust simple, fast, etc.
>> Enough congrats.
>>
>> Working on oxygen-style, though, I find it too bad its "main widget" has
>> a plain solid background color that therefore doesn't match with the
>> rest of the application. I understand, by discussing on IRC#oxygen that
>> it is for okular to properly work in embedded mode (right ?)
>>      
> Eh? What you mean "to properly work in embedded mode"?
>
> Also, to be fair i can't see any difference in the two screenshots you posted,
> could you post a more obvious difference for us poor hard vision dudes?
>
> Thanks for caring about okular :-)
>
> Albert
>
>    
>> Looking into the code I came with the patch (which seems to make both
>> shell and embedding ok) attached.
>>
>> Looks too simple to be true. (though it really does seem to work). Am I
>> missing something ?
>> If not, could that make it to svn, possibly backported to kde4.4 ?
>>
>> Cheers, and sorry if I'm just being naive here.
>>
>> Hugo
>>
>>      
> _______________________________________________
> Okular-devel mailing list
> Okular-devel at kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
>