[Okular-devel] [patch]Document information

[Albert Astals Cid]

A Diumenge, 1 de març de 2009, Luigi Toscano va escriure:
> Hi,
> before I forget *again* and the freeze time comes, I'd like an opinion
> on a patch for okular that I wrote some time ago.
>
> The attached patch changes a bit the handling of document informations
> and the informations shown in the info page.
> - document path is added to the information and a button allows you to
> toggle between to file name (default) and the complete path;
> - the number of the page is added to the information set by
> documentInfo() and not by the properties dialog (so the latter will not
> modify datas);
> - the order of the information shown is the fixed now (see
> orderedProperties).
>
> Can I commit it?

I'm not the maintainer but after having a look i see this: 

   if (DocumentInfo *tmp = const_cast< DocumentInfo * >( (d->m_generator-
>generateDocumentInfo() )))
do you really need the const_cast?

Otherwise it looks okaish to me.

Noone else has an opinion?

Albert

>
> Thanks,