[Okular-devel] PATCH: Allow displaying the file name as a window title

[Pino Toscano]

Hi,

> The attached patch I'm sending allows the user to ignore the document title
> if desired (by changing a checkbox in the settings), recovering the "old"
> KPDF behaviour of displaying always the file name as window title (not only
> when is empty).

As also discussed on IRC a couple of weeks ago, I think the patch is generally 
ok. I didn't apply the UI configuration, either because we are in string 
freeze, and because I'm not sure it is really worth it...
Anyway, committed.

> I haven't changed anything in
> setupPrint() because I'm not sure when the document title is used in
> printing (never noticed the title),

The title is used for the resulting PS/PDF document. Should not harm having it 
here, I guess.

> Besides that, another small comment:
>
> I've tried to add "whatsthis", "label" and "tooltip" elements to the kcfg
> file (as stated in the KConfig XT tutorial), but I haven't noticed any
> change in the dialog, with or without these elements. Then I checked that
> adding this properties in designer does the trick, but I was unsure about
> what to do.

You need
  SetUserTexts=true
in the .kcfgc file.

> I think that some options in the configuration dialog are not that self
> explanatory, and that a tooltip would be very very useful to new users. I
> have some free time this weekend, and I was thinking in adding these
> tooltips before the string freeze on Monday. What do you think? I could
> send the patches for review before committing of course.

Now it's too late, my fault :/
But if you want, you can do the job ahead for KDE 4.3 :)
Posting here for review is fine too, yes.

Cheers,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/okular-devel/attachments/20081129/6677b399/attachment.sig