[Okular-devel] [PATCH] inhibit screen saver during presentation mode

[Tobias Koenig]

On Sat, Aug 30, 2008 at 04:53:50PM +0200, Pino Toscano wrote:
> Hi Tobias,
Hej Pino,

> The patch is mostly ok, just a couple of notes/questions:
> 
> a) can it happen that there are users that do want energy settings in 
> presentation mode anyway?
No idea... so adding a configure option?

> b) instead of inhibitScreenSaver(bool), what about 
> inhibitScreenSaver()+allowScreenSaver()?
Yes, just wanted to have the code in one place, but I can
split it to two methods if you want.

> c)
> > +        QDBusMessage reply = QDBusConnection::sessionBus().call( message );
> > +        if ( reply.type() == QDBusMessage::ReplyMessage )
> > +            m_screenSaverCookie = reply.arguments().first().toInt();
> 
> what about a simplier
> QDBusReply< int > reply = QDBusConnection::sessionBus().call( message );
> if ( reply.isValid() )
>     m_screenSaverCookie = reply.value();
> ?
Fine with me :)

> d) the position of the brackets, please ;)
?

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://mail.kde.org/pipermail/okular-devel/attachments/20080830/8348dc74/attachment.sig