[Nepomuk] Review Request 117420: Fixes issue with full path of excluded directory not being shown

[Lindsay Mathieson]

> On April 7, 2014, 11:23 p.m., Vishesh Handa wrote:
> > I'm not inclined to accept this patch, you know my rationale. If you really want this then please only show the full path when there are duplicates.
> > 
> > Also, please contact the usability team and run it by them.

I thought you were going to ask them about, but ok - will do.

"If you really want this then please only show the full path when there are duplicates."

Even more inconsistent.


> On April 7, 2014, 11:23 p.m., Vishesh Handa wrote:
> > src/file/kcm/folderselectionwidget.cpp, line 254
> > <https://git.reviewboard.kde.org/r/117420/diff/1/?file=263308#file263308line254>
> >
> >     What about this one?

Thanks, missed that.


- Lindsay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/#review55153
-----------------------------------------------------------


On April 7, 2014, 9:59 p.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117420/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 9:59 p.m.)
> 
> 
> Review request for Baloo and Nepomuk.
> 
> 
> Bugs: 333155
>     http://bugs.kde.org/show_bug.cgi?id=333155
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.
> 
> 
> Diffs
> -----
> 
>   src/file/kcm/folderselectionwidget.cpp bc87a33 
> 
> Diff: https://git.reviewboard.kde.org/r/117420/diff/
> 
> 
> Testing
> -------
> 
> Build, installed - opens KCM module, full paths displayed, with ample room.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20140407/895877d7/attachment.html>