[Nepomuk] Review Request 117420: Fixes issue with full path of excluded directory not being shown

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/#review55153
-----------------------------------------------------------


I'm not inclined to accept this patch, you know my rationale. If you really want this then please only show the full path when there are duplicates.

Also, please contact the usability team and run it by them.


src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117420/#comment38447>

    What about this one?


- Vishesh Handa


On April 7, 2014, 11:59 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117420/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 11:59 a.m.)
> 
> 
> Review request for Baloo and Nepomuk.
> 
> 
> Bugs: 333155
>     http://bugs.kde.org/show_bug.cgi?id=333155
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.
> 
> 
> Diffs
> -----
> 
>   src/file/kcm/folderselectionwidget.cpp bc87a33 
> 
> Diff: https://git.reviewboard.kde.org/r/117420/diff/
> 
> 
> Testing
> -------
> 
> Build, installed - opens KCM module, full paths displayed, with ample room.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20140407/fd7e3839/attachment.html>