[Nepomuk] Review Request 110762: NepomukMainModel: don't crash if the backend is missing

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110762/#review33640
-----------------------------------------------------------

Ship it!


This is more of an installation problem, but I guess it should be fixed.

Thanks for the patch.

- Vishesh Handa


On June 1, 2013, 8:44 a.m., Michael Olbrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110762/
> -----------------------------------------------------------
> 
> (Updated June 1, 2013, 8:44 a.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> If creating a backend fails then 'backend' is NULL. An error is printed but initialization continues. With this patch 'virtuosoModel' is set to NULL if 'backend' is NULL instead of trying to dereference the NULL pointer. A NULL 'virtuosoModel' is valid: model() creates a dummy model in this case.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/nepomukmainmodel.cpp a7c4dfd 
> 
> Diff: http://git.reviewboard.kde.org/r/110762/diff/
> 
> 
> Testing
> -------
> 
> nepomukshell and others don't crash any more. I just get lots of "Could not find virtuoso backend" errors.
> 
> 
> Thanks,
> 
> Michael Olbrich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130603/3733b071/attachment.html>