[Nepomuk] Review Request 110762: NepomukMainModel: don't crash if the backend is missing

Michael Olbrich michael.olbrich at gmx.net
Sat Jun 1 08:44:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110762/
-----------------------------------------------------------

Review request for Nepomuk.


Description
-------

If creating a backend fails then 'backend' is NULL. An error is printed but initialization continues. With this patch 'virtuosoModel' is set to NULL if 'backend' is NULL instead of trying to dereference the NULL pointer. A NULL 'virtuosoModel' is valid: model() creates a dummy model in this case.


Diffs
-----

  libnepomukcore/resource/nepomukmainmodel.cpp a7c4dfd 

Diff: http://git.reviewboard.kde.org/r/110762/diff/


Testing
-------

nepomukshell and others don't crash any more. I just get lots of "Could not find virtuoso backend" errors.


Thanks,

Michael Olbrich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130601/3d063beb/attachment.html>


More information about the Nepomuk mailing list