[Nepomuk] Review Request 108550: Cancel in-flight dbus queries to avoid leaks.

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108550/#review26179
-----------------------------------------------------------

Ship it!


The blocking isn't really a problem since it will be for a very very small amount of time. Nepomuk just needs to register the object path on dbus. It doesn't start running the query until explicitly called.

- Vishesh Handa


On Jan. 25, 2013, 4:13 p.m., Till Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108550/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 4:13 p.m.)
> 
> 
> Review request for Nepomuk, David Faure and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Cancel in-flight dbus queries to avoid leaks.
> 
> If close() is called on the query service client while dbus queries
> are still in flight, they were left dangling. This change makes sure they are
> properly cancelled. Without this, all such dangling queries are maintained by
> nepomuk and updated constantly, causing extreme loads, over time.
> 
> 
> Diffs
> -----
> 
>   nepomuk/query/queryserviceclient.cpp 7d3ef0fdff56ae91b89ab95d140634af06b4c218 
> 
> Diff: http://git.reviewboard.kde.org/r/108550/diff/
> 
> 
> Testing
> -------
> 
> I've been running this for several hours with no more hanging queries. Used to accumulate 10 or more in the same time frame before.
> 
> 
> Thanks,
> 
> Till Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130125/90093745/attachment.html>