[Nepomuk] Review Request 108550: Cancel in-flight dbus queries to avoid leaks.

[Till Adam]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108550/
-----------------------------------------------------------

(Updated Jan. 25, 2013, 4:13 p.m.)


Review request for Nepomuk, David Faure and Vishesh Handa.


Description
-------

Cancel in-flight dbus queries to avoid leaks.

If close() is called on the query service client while dbus queries
are still in flight, they were left dangling. This change makes sure they are
properly cancelled. Without this, all such dangling queries are maintained by
nepomuk and updated constantly, causing extreme loads, over time.


Diffs (updated)
-----

  nepomuk/query/queryserviceclient.cpp 7d3ef0fdff56ae91b89ab95d140634af06b4c218 

Diff: http://git.reviewboard.kde.org/r/108550/diff/


Testing
-------

I've been running this for several hours with no more hanging queries. Used to accumulate 10 or more in the same time frame before.


Thanks,

Till Adam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130125/f1f01eca/attachment.html>