[Nepomuk] Review Request 108466: Start the fileindexer on Normal mode when the BasicIndexer finished (now working)

[Jörg Ehrichs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108466/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

In case the NormalMode_FileIndexing in the nepomukstrigirc file is set
to resume, the fileindexer will be started when the basicindexer send
the finishedIndexing signal.
    
Instead of calling the slotScheduleIndexing slot which will start the
basic indexer again (thus crash) a differend slot is called that checks
only for normal mode and if the the fileindexer should start.
    
This way the fileindexer start right away for new files and does not
wait for the next 2min idletime to extract metadata from the file.

This should go into master so it can be tested properly with 4.11


Diffs
-----

  services/fileindexer/indexscheduler.h 64ed4c3 
  services/fileindexer/indexscheduler.cpp 61aac94 

Diff: http://git.reviewboard.kde.org/r/108466/diff/


Testing
-------

yes.
Double checked that its not going to crash like the last try

To test this:
* add to nepomukstrigirc [Indexing]
* NormalMode_FileIndexing = resume
* start nepomukservicestub nepomukfileindexer
* copy a new file into one of the watched folders


Thanks,

Jörg Ehrichs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130118/1cb4b9aa/attachment.html>