<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108466/">http://git.reviewboard.kde.org/r/108466/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Vishesh Handa.</div>
<div>By Jörg Ehrichs.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In case the NormalMode_FileIndexing in the nepomukstrigirc file is set
to resume, the fileindexer will be started when the basicindexer send
the finishedIndexing signal.
Instead of calling the slotScheduleIndexing slot which will start the
basic indexer again (thus crash) a differend slot is called that checks
only for normal mode and if the the fileindexer should start.
This way the fileindexer start right away for new files and does not
wait for the next 2min idletime to extract metadata from the file.
This should go into master so it can be tested properly with 4.11</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes.
Double checked that its not going to crash like the last try
To test this:
* add to nepomukstrigirc [Indexing]
* NormalMode_FileIndexing = resume
* start nepomukservicestub nepomukfileindexer
* copy a new file into one of the watched folders
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/indexscheduler.h <span style="color: grey">(64ed4c3)</span></li>
<li>services/fileindexer/indexscheduler.cpp <span style="color: grey">(61aac94)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>