[Nepomuk] Review Request: Bug 303875 - 'Tags' properties with different font color in tooltip widget

[Frank Reininghaus]

> On Jan. 11, 2013, 7:22 p.m., Vishesh Handa wrote:
> > This seems fine to me, but I cannot really give it a "Ship it" as I'm not too sure if this is the correct way of doing it. Perhaps you could add the dolphin / some-other group. Someone who knows has experience with widgets?

It does look good to me, but I just asked Christoph, who handled the bug report in the first place, to have a look (I'm not that familiar with color handling stuff either). Thanks Emmanuel for taking care of all these small bugs - you are really making the KDE 4.10 user experience better :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108335/#review25256
-----------------------------------------------------------


On Jan. 11, 2013, 7:24 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108335/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 7:24 p.m.)
> 
> 
> Review request for Dolphin, Nepomuk and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Use right foreground role in Nepomuk2::TagCheckBox::m_label
> 
> 
> This addresses bug 303875.
>     http://bugs.kde.org/show_bug.cgi?id=303875
> 
> 
> Diffs
> -----
> 
>   ui/tagcheckbox.cpp 7e402c2 
>   ui/tagwidget.cpp 5d1ef1c 
> 
> Diff: http://git.reviewboard.kde.org/r/108335/diff/
> 
> 
> Testing
> -------
> 
> Done. Screenshot attached
> 
> 
> Screenshots
> -----------
> 
> Old and new look (screenshot includes also the html tags patch)
>   http://git.reviewboard.kde.org/r/108335/s/1020/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130111/c64637a9/attachment.html>