[Nepomuk] Review Request: Bug 303875 - 'Tags' properties with different font color in tooltip widget

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108335/#review25256
-----------------------------------------------------------


This seems fine to me, but I cannot really give it a "Ship it" as I'm not too sure if this is the correct way of doing it. Perhaps you could add the dolphin / some-other group. Someone who knows has experience with widgets?

- Vishesh Handa


On Jan. 10, 2013, 8:01 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108335/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 8:01 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Use right foreground role in Nepomuk2::TagCheckBox::m_label
> 
> 
> This addresses bug 303875.
>     http://bugs.kde.org/show_bug.cgi?id=303875
> 
> 
> Diffs
> -----
> 
>   ui/tagcheckbox.cpp 7e402c2 
>   ui/tagwidget.cpp 5d1ef1c 
> 
> Diff: http://git.reviewboard.kde.org/r/108335/diff/
> 
> 
> Testing
> -------
> 
> Done. Screenshot attached
> 
> 
> Screenshots
> -----------
> 
> Old and new look (screenshot includes also the html tags patch)
>   http://git.reviewboard.kde.org/r/108335/s/1020/
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130111/ad61cdae/attachment.html>