[Nepomuk] Review Request: FileWatcher: Correct the isDir flag in KInotify's deleted() signal

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108338/#review25200
-----------------------------------------------------------

Ship it!


Awesome! Please commit for KDE/4.10

- Vishesh Handa


On Jan. 10, 2013, 10:41 p.m., Gabriel Poesia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108338/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 10:41 p.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Fix the "FIXME: Emit true for directories." in KInotify::slotClearCookies() by storing the inotify event's flags together with the path in the cookies and checking if the IN_ISDIR flag is set when emitting the deleted() signal.
> 
> 
> Diffs
> -----
> 
>   services/filewatch/kinotify.cpp 1a1cd1e 
> 
> Diff: http://git.reviewboard.kde.org/r/108338/diff/
> 
> 
> Testing
> -------
> 
> Wrote a kDebug() message in KInotify::slotClearCookies() to show what is being output in the isDir parameter. It works.
> 
> 
> Thanks,
> 
> Gabriel Poesia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130110/a173d553/attachment-0001.html>