[Nepomuk] Review Request: FileWatcher: Correct the isDir flag in KInotify's deleted() signal

Gabriel Poesia gabriel.poesia at gmail.com
Thu Jan 10 22:41:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108338/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

Fix the "FIXME: Emit true for directories." in KInotify::slotClearCookies() by storing the inotify event's flags together with the path in the cookies and checking if the IN_ISDIR flag is set when emitting the deleted() signal.


Diffs
-----

  services/filewatch/kinotify.cpp 1a1cd1e 

Diff: http://git.reviewboard.kde.org/r/108338/diff/


Testing
-------

Wrote a kDebug() message in KInotify::slotClearCookies() to show what is being output in the isDir parameter. It works.


Thanks,

Gabriel Poesia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130110/56f15cb5/attachment.html>


More information about the Nepomuk mailing list