[Nepomuk] Review Request: FileWatch: Do not always add inotify watches for removable media
Commit Hook
null at kde.org
Wed Jan 2 20:13:23 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108047/#review24496
-----------------------------------------------------------
This review has been submitted with commit 19f9f3fcc094ad65d4b11eb2fd1d5fc20c3a255e by Vishesh Handa to branch KDE/4.10.
- Commit Hook
On Dec. 31, 2012, 9:41 a.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108047/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2012, 9:41 a.m.)
>
>
> Review request for Nepomuk.
>
>
> Description
> -------
>
> FileWatch: Do not always add inotify watches for removable media
>
> Not everyone wants watches to be added to the removable media. They are
> okay with loosing tags/ratings and in removable media. Also, certain
> users do not watch watches ever added for Network Shares - It results in
> a large amount of network load which is not required.
>
> The following options can disable watches in nepomukstrigirc -
>
> [RemovableMedia]
> add watches=true
> add watches network share=false
>
> By default watches are never added to network shares, and they are
> always added for removable media.
>
> BUG: 308474
>
>
> This addresses bug 308474.
> http://bugs.kde.org/show_bug.cgi?id=308474
>
>
> Diffs
> -----
>
> services/filewatch/nepomukfilewatch.cpp e809bcf
>
> Diff: http://git.reviewboard.kde.org/r/108047/diff/
>
>
> Testing
> -------
>
> Not really. I don't have any network shares. I will test it out with a pen-drive later.
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130102/e6074364/attachment.html>
More information about the Nepomuk
mailing list