[Nepomuk] Review Request: FileWatch: Do not add watches for system links

Commit Hook null at kde.org
Wed Jan 2 20:13:23 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108025/#review24495
-----------------------------------------------------------


This review has been submitted with commit 3daabb6407383b0620b8c6db9973fc9be8f0a6fd by Vishesh Handa to branch KDE/4.10.

- Commit Hook


On Dec. 31, 2012, 9:49 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108025/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 9:49 a.m.)
> 
> 
> Review request for Nepomuk and Simeon Bird.
> 
> 
> Description
> -------
> 
>     Following system links can lead to various infinite cycles, which is
>     something we do not ever want.
>     
>     I'm not sure if there is any advantage gained by adding watches to them?
> 
> 
> Diffs
> -----
> 
>   services/filewatch/kinotify.cpp 747b67c 
>   services/filewatch/nepomukfilewatch.cpp e809bcf 
> 
> Diff: http://git.reviewboard.kde.org/r/108025/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130102/a71811b1/attachment.html>


More information about the Nepomuk mailing list