[Nepomuk] Review Request 109018: Start testing the nepomuk file indexer plugins

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109018/#review28167
-----------------------------------------------------------

Ship it!


It seems as though you've forgotten to add the services/fileindexer/indexer/test/CMakeLists.txt to this patch. Otherwise, everything seems perfect!


services/fileindexer/indexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment21058>

    Oh. Could you please use a relative include over here?
    
    We seem to be using relative includes in nepomuk-core.
    
    #include "../plaintextextractor.h"


- Vishesh Handa


On Feb. 21, 2013, 10:54 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109018/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 10:54 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Start testing the nepomuk file indexer plugins
> 
> Tests the generated resource graph for the plain text extractor against a sample file
> 
> Obviously this needs extending for all the plugins but I wanted to start with one and agree on the plan/structure before I do any more.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/test/samplefiles/README PRE-CREATION 
>   services/fileindexer/indexer/test/samplefiles/plain_text_file.txt PRE-CREATION 
>   services/fileindexer/indexer/CMakeLists.txt f7b5d2a29dc4098cda3997f338adf45b211c4872 
>   services/fileindexer/indexer/test/indexerextractortests.h PRE-CREATION 
>   services/fileindexer/indexer/test/indexerextractortests.cpp PRE-CREATION 
>   services/fileindexer/indexer/test/indexerextractortestsconfig.h.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109018/diff/
> 
> 
> Testing
> -------
> 
> Sample output.
> 
> ********* Start testing of IndexerExtractorTests *********
> Config: Using QTest library 4.8.3, Qt 4.8.3
> PASS   : IndexerExtractorTests::initTestCase()
> RESULT : IndexerExtractorTests::benchMarkPlainTextExtractor():
>      0.042 msecs per iteration (total: 88, iterations: 2048)
> PASS   : IndexerExtractorTests::benchMarkPlainTextExtractor()
> PASS   : IndexerExtractorTests::testPlainTextExtractor()
> PASS   : IndexerExtractorTests::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> ********* Finished testing of IndexerExtractorTests *********
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130226/8bbbd1f1/attachment.html>