<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109018/">http://git.reviewboard.kde.org/r/109018/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems as though you've forgotten to add the services/fileindexer/indexer/test/CMakeLists.txt to this patch. Otherwise, everything seems perfect!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109018/diff/2/?file=114926#file114926line33" style="color: black; font-weight: bold; text-decoration: underline;">services/fileindexer/indexer/test/indexerextractortests.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "services/fileindexer/indexer/plaintextextractor.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh. Could you please use a relative include over here?
We seem to be using relative includes in nepomuk-core.
#include "../plaintextextractor.h"</pre>
</div>
<br />
<p>- Vishesh</p>
<br />
<p>On February 21st, 2013, 10:54 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2013, 10:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Start testing the nepomuk file indexer plugins
Tests the generated resource graph for the plain text extractor against a sample file
Obviously this needs extending for all the plugins but I wanted to start with one and agree on the plan/structure before I do any more.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sample output.
********* Start testing of IndexerExtractorTests *********
Config: Using QTest library 4.8.3, Qt 4.8.3
PASS : IndexerExtractorTests::initTestCase()
RESULT : IndexerExtractorTests::benchMarkPlainTextExtractor():
0.042 msecs per iteration (total: 88, iterations: 2048)
PASS : IndexerExtractorTests::benchMarkPlainTextExtractor()
PASS : IndexerExtractorTests::testPlainTextExtractor()
PASS : IndexerExtractorTests::cleanupTestCase()
Totals: 4 passed, 0 failed, 0 skipped
********* Finished testing of IndexerExtractorTests *********</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/indexer/test/samplefiles/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/indexer/test/samplefiles/plain_text_file.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/indexer/CMakeLists.txt <span style="color: grey">(f7b5d2a29dc4098cda3997f338adf45b211c4872)</span></li>
<li>services/fileindexer/indexer/test/indexerextractortests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/indexer/test/indexerextractortests.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>services/fileindexer/indexer/test/indexerextractortestsconfig.h.in <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109018/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>