[Nepomuk] Review Request 109078: Add a base class for the file watcher back-ends

[Gabriel Poesia]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109078/
-----------------------------------------------------------

(Updated Feb. 25, 2013, 5:08 p.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

Added Trueg's copyright statement (from kinotify.h) to filesystemmonitor.h, as most code there is his (taken from kinotify.h).

So, should I follow with this, implementing the two subclasses that use inotify and kDirNotify?


Description
-------

This is about this task: http://community.kde.org/Projects/Nepomuk/4.11#File_Watcher

This abstract FileSystemMonitor class is basically the generic interface extracted from KInotify.
It also has a method to ignore paths based on a RegExpCache filter list, just like IgnoringKInotify.


Diffs (updated)
-----

  services/filewatch/filesystemmonitor.h PRE-CREATION 
  services/filewatch/filesystemmonitor.cpp PRE-CREATION 
  services/filewatch/test/CMakeLists.txt 8b6ebe6 
  services/filewatch/test/filesystemmonitortest.h PRE-CREATION 
  services/filewatch/test/filesystemmonitortest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109078/diff/


Testing
-------

The empty test that includes it compiles.


Thanks,

Gabriel Poesia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130225/4edf2d13/attachment.html>