[Nepomuk] Review Request 109018: Start testing the nepomuk file indexer plugins

[David Edmundson]

> On Feb. 19, 2013, 9:21 a.m., Vishesh Handa wrote:
> > Seems good apart from the minor issues. Also, I'm not sure if this should be in fileindexer/tests or fileindexer/indexer/tests. It does test the "indexer" part of the "file indexer" (The FileIndexer is just responsible for scheduling the indexing).

Could you clarify that "I'm not sure if" means "MOVE IT!".


> On Feb. 19, 2013, 9:21 a.m., Vishesh Handa wrote:
> > services/fileindexer/test/indexerextractortests.cpp, line 60
> > <http://git.reviewboard.kde.org/r/109018/diff/1/?file=114372#file114372line60>
> >
> >     I'm a little confused. What is this content variable for and why is it being filled? It's not even being used anywhere.

It's used in the line below QTextStream(&content) to get populated.

Then used in one of the QVERIFYs


> On Feb. 19, 2013, 9:21 a.m., Vishesh Handa wrote:
> > services/fileindexer/test/indexerextractortests.cpp, line 58
> > <http://git.reviewboard.kde.org/r/109018/diff/1/?file=114372#file114372line58>
> >
> >     I think the syntax is extract( resUri, fileUrl, mimetype ). It's a little confusing if you pass the fileUrl as the resUri. How about you just create a random resource uri -
> >     
> >     QUrl resUri("nepomuk:/res/A");
> >     and pass that?

Thanks. Will change, I wasn't really sure what to pass for this.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109018/#review27709
-----------------------------------------------------------


On Feb. 18, 2013, 11:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109018/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 11:27 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Start testing the nepomuk file indexer plugins
> 
> Tests the generated resource graph for the plain text extractor against a sample file
> 
> Obviously this needs extending for all the plugins but I wanted to start with one and agree on the plan/structure before I do any more.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/test/indexerextractortestsconfig.h.in PRE-CREATION 
>   services/fileindexer/test/samplefiles/README PRE-CREATION 
>   services/fileindexer/test/samplefiles/plain_text_file.txt PRE-CREATION 
>   services/fileindexer/test/CMakeLists.txt 49a527f39f6f07afebf8bcd14902b63948c1c33d 
>   services/fileindexer/test/indexerextractortests.h PRE-CREATION 
>   services/fileindexer/test/indexerextractortests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109018/diff/
> 
> 
> Testing
> -------
> 
> Sample output.
> 
> ********* Start testing of IndexerExtractorTests *********
> Config: Using QTest library 4.8.3, Qt 4.8.3
> PASS   : IndexerExtractorTests::initTestCase()
> RESULT : IndexerExtractorTests::benchMarkPlainTextExtractor():
>      0.042 msecs per iteration (total: 88, iterations: 2048)
> PASS   : IndexerExtractorTests::benchMarkPlainTextExtractor()
> PASS   : IndexerExtractorTests::testPlainTextExtractor()
> PASS   : IndexerExtractorTests::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> ********* Finished testing of IndexerExtractorTests *********
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130219/02b5d09d/attachment.html>