[Nepomuk] Review Request 109018: Start testing the nepomuk file indexer plugins

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109018/#review27709
-----------------------------------------------------------


Seems good apart from the minor issues. Also, I'm not sure if this should be in fileindexer/tests or fileindexer/indexer/tests. It does test the "indexer" part of the "file indexer" (The FileIndexer is just responsible for scheduling the indexing).


services/fileindexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment20779>

    I think you'll need to use local includes. The "Nepomuk2/SimpleResourceGraph" is only installed when nepomuk-core is installed. Since this file is a part of nepomuk-core, I don't think this would work without nepomuk-core being installed.
    
    Just use "simpleresourcegraph.h"



services/fileindexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment20778>

    Do you mind adding a 'using namespace Soprano::Vocabulary' as well. That way you won't have to type 'Soprano::Vocabulary::RDF::type()', you can just type "RDF::type()" which is IMO much cleaner.



services/fileindexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment20775>

    I think the syntax is extract( resUri, fileUrl, mimetype ). It's a little confusing if you pass the fileUrl as the resUri. How about you just create a random resource uri -
    
    QUrl resUri("nepomuk:/res/A");
    and pass that?



services/fileindexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment20777>

    I'm a little confused. What is this content variable for and why is it being filled? It's not even being used anywhere.



services/fileindexer/test/indexerextractortests.cpp
<http://git.reviewboard.kde.org/r/109018/#comment20776>

    You could use that resUri over here.


- Vishesh Handa


On Feb. 18, 2013, 11:27 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109018/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 11:27 p.m.)
> 
> 
> Review request for Nepomuk.
> 
> 
> Description
> -------
> 
> Start testing the nepomuk file indexer plugins
> 
> Tests the generated resource graph for the plain text extractor against a sample file
> 
> Obviously this needs extending for all the plugins but I wanted to start with one and agree on the plan/structure before I do any more.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/test/indexerextractortestsconfig.h.in PRE-CREATION 
>   services/fileindexer/test/samplefiles/README PRE-CREATION 
>   services/fileindexer/test/samplefiles/plain_text_file.txt PRE-CREATION 
>   services/fileindexer/test/CMakeLists.txt 49a527f39f6f07afebf8bcd14902b63948c1c33d 
>   services/fileindexer/test/indexerextractortests.h PRE-CREATION 
>   services/fileindexer/test/indexerextractortests.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109018/diff/
> 
> 
> Testing
> -------
> 
> Sample output.
> 
> ********* Start testing of IndexerExtractorTests *********
> Config: Using QTest library 4.8.3, Qt 4.8.3
> PASS   : IndexerExtractorTests::initTestCase()
> RESULT : IndexerExtractorTests::benchMarkPlainTextExtractor():
>      0.042 msecs per iteration (total: 88, iterations: 2048)
> PASS   : IndexerExtractorTests::benchMarkPlainTextExtractor()
> PASS   : IndexerExtractorTests::testPlainTextExtractor()
> PASS   : IndexerExtractorTests::cleanupTestCase()
> Totals: 4 passed, 0 failed, 0 skipped
> ********* Finished testing of IndexerExtractorTests *********
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130219/9844961b/attachment-0001.html>