[Nepomuk] Review Request 108811: Change dbus interface to the FileIndexer for status messages

[Jörg Ehrichs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108811/
-----------------------------------------------------------

(Updated Feb. 13, 2013, 5:08 p.m.)


Review request for Nepomuk and Vishesh Handa.


Changes
-------

Fixed the issues

Expose IndexScheduler::Status via dbus as integer to have more information available that just idle/working/suspended
add dbus method currentStatus so one can query this status value and not just connect to the signal.

Thus removing the need to explicit call isCleaning/isIndexing/isSuspended all the time


Description
-------

To have a unified dbus interface this patch adds the signal:
* statusMessage(int, string)
and the method:
* statusMessage
    
To expose the current state of the fileindexer via dbus.
This change results in the same dbus signal/slot that are used by
akonadi_nepomuk and the FileWatcher.
    
The integers are defined as
status -1: suspended
status  0: idle
status  1: working (processing/searching for files to process)
status  2: cleaning

Therefore the following method s are marked deprecated:
* userStatusString - bad naming, same as statusMessage
* simpleUserStatusString - not used/returns the same as userStatusString


Diffs (updated)
-----

  interfaces/org.kde.nepomuk.FileIndexer.xml 752604b 
  services/fileindexer/fileindexer.h 4c79e48 
  services/fileindexer/fileindexer.cpp 9d4b2a2 
  services/fileindexer/indexscheduler.h d53e7c9 
  services/fileindexer/indexscheduler.cpp ef848e2 

Diff: http://git.reviewboard.kde.org/r/108811/diff/


Testing
-------

* Connected to the status signal via qdbusviewer
* moved files around/added new folders for the indexing.
* output shows current operation + url


Thanks,

Jörg Ehrichs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130213/f52f3d6f/attachment.html>