[Nepomuk] Review Request 109856: FIX: exiv2extractor did not import exif datetime.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109856/
-----------------------------------------------------------

(Updated April 5, 2013, 10:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Nepomuk and Vishesh Handa.


Description
-------

There was a FIXME in exiv2extractor.cpp about datetime exif tag and I wrote the code required to convert information to exif format to xsd:datetime.

I'm using val.setUtcOffset(0) to convert datetime generated by QDateTime::fromString() because datetime information stored in exif is in local time. If there is a better method to do this please inform me.

This fix don't fix exactly the bug https://bugs.kde.org/show_bug.cgi?id=317501 because the bug is related to datetimes collected with strigi, but will permit to reindex images and solve the issue. In brief I'm not sure if I must assign this review to the bug or not.


This addresses bug 317501.
    http://bugs.kde.org/show_bug.cgi?id=317501


Diffs
-----

  services/fileindexer/indexer/exiv2extractor.cpp 7c7fe21 
  services/fileindexer/indexer/extractorplugin.cpp 5d834c9 

Diff: http://git.reviewboard.kde.org/r/109856/diff/


Testing
-------

With several photos in JPEG and NEF format comparing values obtained by extractor with values obtained by Digikam and exiv2 console program.


Thanks,

Ignacio Serantes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130405/29b1addf/attachment-0001.html>