[Nepomuk] Review Request 109801: Fix: rational type exif values was not imported and FValue field was missing

[Ignacio Serantes]

> On April 1, 2013, 10:09 a.m., Vishesh Handa wrote:
> > services/fileindexer/indexer/exiv2extractor.cpp, line 55
> > <http://git.reviewboard.kde.org/r/109801/diff/1/?file=126712#file126712line55>
> >
> >     Why remove the tiff format?

I don't removed it, I did a reorder of mimetypes.


> On April 1, 2013, 10:09 a.m., Vishesh Handa wrote:
> > services/fileindexer/indexer/exiv2extractor.cpp, line 61
> > <http://git.reviewboard.kde.org/r/109801/diff/1/?file=126712#file126712line61>
> >
> >     ditto

Ditto.


- Ignacio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109801/#review30194
-----------------------------------------------------------


On March 30, 2013, 11:21 a.m., Ignacio Serantes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109801/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 11:21 a.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Rational type Exif values was not imported because conversion to double was failing. Some of the not imported tags was: Exposure Bias Value Exposure Time or Focal Length.
> 
> On the other side FNumber field was missing so I added it.
> 
> Finally I sorted mimetypes so it's easy to locate missing one.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/exiv2extractor.cpp 4d7b6d9 
> 
> Diff: http://git.reviewboard.kde.org/r/109801/diff/
> 
> 
> Testing
> -------
> 
> With some photos taken with a Nikon D5000 converted to PNG and values match the ones obtained calling exiv2 command in console.
> 
> 
> Thanks,
> 
> Ignacio Serantes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130401/a802bced/attachment.html>