[Nepomuk] Review Request 109801: Fix: rational type exif values was not imported and FValue field was missing

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109801/#review30194
-----------------------------------------------------------



services/fileindexer/indexer/exiv2extractor.cpp
<http://git.reviewboard.kde.org/r/109801/#comment22496>

    Why remove the tiff format?



services/fileindexer/indexer/exiv2extractor.cpp
<http://git.reviewboard.kde.org/r/109801/#comment22497>

    ditto


- Vishesh Handa


On March 30, 2013, 10:21 a.m., Ignacio Serantes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109801/
> -----------------------------------------------------------
> 
> (Updated March 30, 2013, 10:21 a.m.)
> 
> 
> Review request for Nepomuk and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Rational type Exif values was not imported because conversion to double was failing. Some of the not imported tags was: Exposure Bias Value Exposure Time or Focal Length.
> 
> On the other side FNumber field was missing so I added it.
> 
> Finally I sorted mimetypes so it's easy to locate missing one.
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/indexer/exiv2extractor.cpp 4d7b6d9 
> 
> Diff: http://git.reviewboard.kde.org/r/109801/diff/
> 
> 
> Testing
> -------
> 
> With some photos taken with a Nikon D5000 converted to PNG and values match the ones obtained calling exiv2 command in console.
> 
> 
> Thanks,
> 
> Ignacio Serantes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20130401/9b79c8fb/attachment.html>