[Nepomuk] Review Request: Fix race conditions in nepomuk's ResourceData.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105562/#review19566
-----------------------------------------------------------


This review has been submitted with commit 3262f04643ae5632077f4f91e3c669c277ded656 by David Faure to branch KDE/4.9.

- Commit Hook


On Sept. 6, 2012, 6:13 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105562/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 6:13 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Fix race conditions in nepomuk's ResourceData.
> 
> Found with "helgrind kmail --nofork", inbox, clicking on any email.
> where helgrind is "QT_NO_GLIB=1 valgrind --tool=helgrind --track-lockorders=no"
> 
> The change in resource.cpp avoids a deadlock due to the change
> in resourcedata: no need to hold the rmMutex for the determineUri call.
> 
> 
> This addresses bug 295802.
>     http://bugs.kde.org/show_bug.cgi?id=295802
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcemanager.cpp 2a6668a 
>   libnepomukcore/resource/resourcedata.cpp c14582f 
>   libnepomukcore/resource/resourcedata.h 7e185a7 
> 
> Diff: http://git.reviewboard.kde.org/r/105562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120929/b9ac83b8/attachment-0001.html>