[Nepomuk] Review Request: Fix race conditions in nepomuk's ResourceData.

David Faure faure at kde.org
Thu Sep 6 18:13:33 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 6, 2012, 6:13 p.m.)

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


forgot to remove old code from slotPropertyAdded().


Fix race conditions in nepomuk's ResourceData.

Found with "helgrind kmail --nofork", inbox, clicking on any email.
where helgrind is "QT_NO_GLIB=1 valgrind --tool=helgrind --track-lockorders=no"

The change in resource.cpp avoids a deadlock due to the change
in resourcedata: no need to hold the rmMutex for the determineUri call.

This addresses bug 295802.

Diffs (updated)

  libnepomukcore/resource/resourcemanager.cpp 2a6668a 
  libnepomukcore/resource/resourcedata.cpp c14582f 
  libnepomukcore/resource/resourcedata.h 7e185a7 

Diff: http://git.reviewboard.kde.org/r/105562/diff/



David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120906/5ccb32f5/attachment.html>

More information about the Nepomuk mailing list