[Nepomuk] Review Request: Soprano: Combine Server and Client streams into a new DataStream class
Commit Hook
null at kde.org
Mon Oct 22 06:29:09 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106568/#review20650
-----------------------------------------------------------
This review has been submitted with commit 5b1207b7ed1ef73adc1f1a82baa6752eddb51609 by Vishesh Handa to branch master.
- Commit Hook
On Sept. 25, 2012, 2:56 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106568/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2012, 2:56 p.m.)
>
>
> Review request for Nepomuk, Soprano and Sebastian Trueg.
>
>
> Description
> -------
>
> Combine Server and Client streams into a new DataStream class
>
> Instead of both the server and the client implementing their own
> streaming operators. We combine all the streaming operators into a new
> public class called Soprano::DataStream.
>
> The Server and Client create their own respective class -
> ServerDataStream and SocketStream respectively. The just have to
> implement a read and write function.
>
> This serves to eliminate code duplication, and allows others to use the
> DataStream class, if they need it.
>
>
> Diffs
> -----
>
> client/CMakeLists.txt 4e73e3c
> client/socketstream.h a7b1eb2
> client/socketstream.cpp 36472f1
> server/CMakeLists.txt 8155648
> server/datastream.h 0ecf2d3
> server/datastream.cpp f98ee2d
> server/serverconnection.cpp 786f9df
> server/serverdatastream.h PRE-CREATION
> server/serverdatastream.cpp PRE-CREATION
> soprano/CMakeLists.txt 28c3188
> soprano/datastream.h PRE-CREATION
> soprano/datastream.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/106568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121022/8b524941/attachment.html>
More information about the Nepomuk
mailing list