<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106568/">http://git.reviewboard.kde.org/r/106568/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5b1207b7ed1ef73adc1f1a82baa6752eddb51609 by Vishesh Handa to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 25th, 2012, 2:56 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Soprano and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Sept. 25, 2012, 2:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Combine Server and Client streams into a new DataStream class
Instead of both the server and the client implementing their own
streaming operators. We combine all the streaming operators into a new
public class called Soprano::DataStream.
The Server and Client create their own respective class -
ServerDataStream and SocketStream respectively. The just have to
implement a read and write function.
This serves to eliminate code duplication, and allows others to use the
DataStream class, if they need it.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client/CMakeLists.txt <span style="color: grey">(4e73e3c)</span></li>
<li>client/socketstream.h <span style="color: grey">(a7b1eb2)</span></li>
<li>client/socketstream.cpp <span style="color: grey">(36472f1)</span></li>
<li>server/CMakeLists.txt <span style="color: grey">(8155648)</span></li>
<li>server/datastream.h <span style="color: grey">(0ecf2d3)</span></li>
<li>server/datastream.cpp <span style="color: grey">(f98ee2d)</span></li>
<li>server/serverconnection.cpp <span style="color: grey">(786f9df)</span></li>
<li>server/serverdatastream.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/serverdatastream.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>soprano/CMakeLists.txt <span style="color: grey">(28c3188)</span></li>
<li>soprano/datastream.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>soprano/datastream.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>