[Nepomuk] Review Request: Create a taskbar notification window when we run out of inotify watches

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106748/#review20063
-----------------------------------------------------------


Overall, from a programming point of view, the patch is perfect. But I am not sure if we should be adding this. It seems like the distributions job to add a decent inotify limit.

Do you think you could add the kde-usability team to the review? I'd like a second opinion.


services/filewatch/nepomukfilewatch.cpp
<http://git.reviewboard.kde.org/r/106748/#comment15887>

    Maybe one would want to recommend an even higher limit?
    
    Also, "file changes will be ignored" seems a little scary. Maybe we could add the word indexing over there.


- Vishesh Handa


On Oct. 6, 2012, 7:33 p.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106748/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2012, 7:33 p.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Currently, if we happen to run out of inotify watches in the filewatch service, all we get is a debug message, which is easily lost.
> This patch additionally creates a popup notification to warn people they need to raise the limit.
> 
> I worried that a popup might be a bit too invasive - I considered also just logging to syslog, but that seemed not invasive enough. 
> I figured that since metadata can get lost if the watches are not all installed, being fairly invasive is a good idea. 
> 
> What think you?
> 
> 
> Diffs
> -----
> 
>   services/filewatch/nepomukfilewatch.cpp 83045da 
>   services/filewatch/nepomukfilewatch.notifyrc bfa88a9 
> 
> Diff: http://git.reviewboard.kde.org/r/106748/diff/
> 
> 
> Testing
> -------
> 
> > sudo sysctl fs.inotify.max_user_watches=10 
> > killall nepomukserver && nepomukserver
> 
> Yup, there's a notification.
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121008/7eeb11dc/attachment.html>