<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106748/">http://git.reviewboard.kde.org/r/106748/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall, from a programming point of view, the patch is perfect. But I am not sure if we should be adding this. It seems like the distributions job to add a decent inotify limit.
Do you think you could add the kde-usability team to the review? I'd like a second opinion.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106748/diff/1/?file=88551#file88551line332" style="color: black; font-weight: bold; text-decoration: underline;">services/filewatch/nepomukfilewatch.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk2::FileWatch::connectToKDirWatch()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">332</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KNotification</span><span class="o">::</span><span class="n">event</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"nepomuk_inotify_limit"</span><span class="p">)</span> <span class="p">,</span> <span class="n">i18nc</span><span class="p">(</span><span class="s">"@title"</span><span class="p">,</span><span class="s">"Folder watch limit reached."</span><span class="p">)</span> <span class="p">,</span> <span class="n">i18nc</span><span class="p">(</span><span class="s">"@info"</span><span class="p">,</span><span class="s">"Increase limit with 'sudo sysctl fs.inotify.max_user_watches=32768' or file changes will be ignored."</span><span class="p">),</span> <span class="nb">NULL</span> <span class="p">,</span> <span class="mi">0L</span><span class="p">,</span> <span class="n">KNotification</span><span class="o">::</span><span class="n">Persistent</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe one would want to recommend an even higher limit?
Also, "file changes will be ignored" seems a little scary. Maybe we could add the word indexing over there.</pre>
</div>
<br />
<p>- Vishesh</p>
<br />
<p>On October 6th, 2012, 7:33 p.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2012, 7:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, if we happen to run out of inotify watches in the filewatch service, all we get is a debug message, which is easily lost.
This patch additionally creates a popup notification to warn people they need to raise the limit.
I worried that a popup might be a bit too invasive - I considered also just logging to syslog, but that seemed not invasive enough.
I figured that since metadata can get lost if the watches are not all installed, being fairly invasive is a good idea.
What think you?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> sudo sysctl fs.inotify.max_user_watches=10
> killall nepomukserver && nepomukserver
Yup, there's a notification.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(83045da)</span></li>
<li>services/filewatch/nepomukfilewatch.notifyrc <span style="color: grey">(bfa88a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106748/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>