[Nepomuk] Review Request: Resource: Minor optimization while loading the data

Commit Hook null at kde.org
Wed Oct 3 12:00:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106684/#review19819
-----------------------------------------------------------


This review has been submitted with commit c9b1329a69011391b66cad792336d4f811077258 by Vishesh Handa to branch master.

- Commit Hook


On Oct. 2, 2012, 9:39 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106684/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 9:39 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Resource: Minor optimization while loading the data
>     
>     Avoid the double comparsion when loading each property because of
>     updateKickOffLists( .. ). Instead, we directly update the relevant kick
>     off lists after the data has been loaded into the cache.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp 8c4ae34 
> 
> Diff: http://git.reviewboard.kde.org/r/106684/diff/
> 
> 
> Testing
> -------
> 
> All the tests pass
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121003/ce442d15/attachment.html>


More information about the Nepomuk mailing list