[Nepomuk] Review Request: Resource: Minor optimization while loading the data

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106684/#review19769
-----------------------------------------------------------


I'd say that together with an optimization results we should get the statistics on what kind of improvement to expect. Probably unit test runtime difference can be a good start :).

keep up the good work! ^^

- Aleix Pol Gonzalez


On Oct. 2, 2012, 9:39 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106684/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 9:39 a.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
>     Resource: Minor optimization while loading the data
>     
>     Avoid the double comparsion when loading each property because of
>     updateKickOffLists( .. ). Instead, we directly update the relevant kick
>     off lists after the data has been loaded into the cache.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/resource/resourcedata.cpp 8c4ae34 
> 
> Diff: http://git.reviewboard.kde.org/r/106684/diff/
> 
> 
> Testing
> -------
> 
> All the tests pass
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121002/4cb2c600/attachment.html>