[Nepomuk] Review Request: Fix recently introduced bug in the handling of EventUnmount in filewatch

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107259/#review21758
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Trueg


On Nov. 9, 2012, 12:46 a.m., Simeon Bird wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107259/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 12:46 a.m.)
> 
> 
> Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> When we get an EventUnmount with path '/', do not break the while loop.
>   
> Breaking means that we lose any further events in the buffer,
> and that unmounted folders are not correctly removed from
> the path hashes.
>     
> Instead, fix the crash by changing the assert to just not trigger if path is / and the event is EventUnmount.
> Then do not emit unmounted with a meaningless path.
> 
> This fixes a potential bug before it was released anywhere
> 
> 
> Diffs
> -----
> 
>   services/filewatch/kinotify.cpp 54947fc 
> 
> Diff: http://git.reviewboard.kde.org/r/107259/diff/
> 
> 
> Testing
> -------
> 
> Compiled, ran for a while.
> 
> 
> Thanks,
> 
> Simeon Bird
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121110/492856b0/attachment.html>