[Nepomuk] Review Request: Fix recently introduced bug in the handling of EventUnmount in filewatch

Simeon Bird bladud at gmail.com
Fri Nov 9 00:46:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107259/
-----------------------------------------------------------

Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.


Description
-------

When we get an EventUnmount with path '/', do not break the while loop.
  
Breaking means that we lose any further events in the buffer,
and that unmounted folders are not correctly removed from
the path hashes.
    
Instead, fix the crash by changing the assert to just not trigger if path is / and the event is EventUnmount.
Then do not emit unmounted with a meaningless path.

This fixes a potential bug before it was released anywhere


Diffs
-----

  services/filewatch/kinotify.cpp 54947fc 

Diff: http://git.reviewboard.kde.org/r/107259/diff/


Testing
-------

Compiled, ran for a while.


Thanks,

Simeon Bird

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20121109/fc260a93/attachment.html>


More information about the Nepomuk mailing list