[Nepomuk] Review Request: Disable Query excerpts by default

[Vishesh Handa]

> On June 13, 2012, 8:57 a.m., Sebastian Trueg wrote:
> > I am fine with this change.
> > As for the tests: they are annoying to maintain. What we should have are actual query tests against a test db where the results are compared instead of the query string.

I had a chat with some other developers and it seems that my reasons for disabling them are rather idiotic.

Plus, there is no noticable performance decrease, so for now I'm closing this review request :/


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105065/#review14679
-----------------------------------------------------------


On May 27, 2012, 1:37 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105065/
> -----------------------------------------------------------
> 
> (Updated May 27, 2012, 1:37 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> If people want them, they should enable them. There is no advantage of providing them by default. Specially since no one seems to be using them. It also complicates the queries when you're trying to debug stuff. 
>  
> Also, this breaks the existing API a little bit. However, since no one has packaged Nepomuk2 so far, I'm allowed to break stuff.
> 
> 
> Diffs
> -----
> 
>   libnepomukcore/query/query.h f4360b0 
>   libnepomukcore/query/query.cpp d67b6ce 
>   libnepomukcore/query/queryserializer.cpp 0d8bc7e 
>   libnepomukcore/test/queryserializertest.cpp ccc8af6 
>   libnepomukcore/test/querytest.cpp 2a8f685 
> 
> Diff: http://git.reviewboard.kde.org/r/105065/diff/
> 
> 
> Testing
> -------
> 
> Not tested. This also breaks almost all the tests in querytest. I'm waiting to see if trueg is okay with this patch.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120617/293b35c8/attachment-0001.html>