[Nepomuk] Review Request: Show the complete file path when indexing a file

Sebastian Trueg sebastian at trueg.de
Wed Jun 13 08:59:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105013/#review14680
-----------------------------------------------------------



services/fileindexer/fileindexer.cpp
<http://git.reviewboard.kde.org/r/105013/#comment11591>

    the "file" var is pointless now. Just check for m_indexScheduler-currentFile().isEmpty() directly. Otherwise, this is a good change.


- Sebastian Trueg


On May 22, 2012, 2:39 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105013/
> -----------------------------------------------------------
> 
> (Updated May 22, 2012, 2:39 p.m.)
> 
> 
> Review request for Nepomuk and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Read the bug report
> 
> 
> This addresses bug 297308.
>     http://bugs.kde.org/show_bug.cgi?id=297308
> 
> 
> Diffs
> -----
> 
>   services/fileindexer/fileindexer.cpp 2e37130 
> 
> Diff: http://git.reviewboard.kde.org/r/105013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120613/eaee304f/attachment-0001.html>


More information about the Nepomuk mailing list