[Nepomuk] Review Request: LibStreamAnalyzer: Add a version header

[Jos van den Oever]

> On July 26, 2012, 7:31 a.m., Jos van den Oever wrote:
> > Strigi has one version number for the collection of libraries. This version is available in strigiconfig.h which is often stored at /usr/include/strigi/strigiconfig.h
> > This version number applies to libstreams, libstreamanalyzer and the other libraries and executables.
> > 
> > #define STRIGI_VERSION_STRING "0.7.7"
> > #define STRIGI_VERSION_MAJOR 0
> > #define STRIGI_VERSION_MINOR 7
> > #define STRIGI_VERSION_RELEASE 7
> > 
> >
> 
> Vishesh Handa wrote:
>     Yes, but I'd like to know that information at runtime, not compile.
>     
>     Right now, all the indexers do not conform to the ontologies, and some just crash. The files on which those indexers are used never get indexed, and each time Nepomuk restarts, the analyzers are run again. I rather only run the analyzers when the strigi version changes.

Fair enough.
Some tips:
 - do not use a new header, it's not needed, get the values from strigiconfig.h
 - put the functions in Strigi:: namespace (there's more software with version numbers)
 - put the functions in libstreams, not in libstreamanalyzer

Discussion point:
 perhaps it's better to version the actual analyzers, but that's a large change

namespace Strigi {
   unsigned int versionMajor();
   unsigned int versionMinor();
   unsigned int versionPatch();
   const char* versionString();
}


- Jos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105731/#review16455
-----------------------------------------------------------


On July 25, 2012, 4:05 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105731/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 4:05 p.m.)
> 
> 
> Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> This way applications can easily detect the current version of
> libstreamanalyzer and change their behavior during runtime.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6387160 
>   lib/CMakeLists.txt aa989ce 
>   lib/libstreamanalyzer_version.cpp PRE-CREATION 
>   libstreamanalyzer_version.h.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105731/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20120726/6a3c7db2/attachment.html>